Joachim Wiberg
ac63461bd8
confd: fix copy-paste error in dns-resolver
...
Found by Coverity Scan, CID 331048
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
123808d6bb
confd: check return value of mktime()
...
Found by Coverity Scan, CID 331032
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
b2331dc8ce
confd: minor, coding style
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
31bd1286a3
confd: minor, whitespace
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
da6b5a1950
confd: mark unchecked remove()/rename() as intentional
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
1b825d4ac6
confd: fix memory leak in handle_sr_shell_update()
...
Found by Coverity Scan, CID 331029
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
90af510092
confd: fix memory leak in handle_sr_passwd_update()
...
Found by Coverity Scan, CID 331033
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
c3045ecebb
confd: fix obvious mistakes in checking return values
...
Found by Coverty Scan
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
f56baeb4fa
confd: drop malplaced sr_free_values()
...
We haven't even called sr_get_items() yet. Must've been a remnant
of an earlier refactor.
Fixes CID 331051
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Joachim Wiberg
2191202f2a
statd: null terminate recv() buffer from netlink
...
Fixes CID 331053
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-20 13:34:19 +01:00
Tobias Waldekranz and Joachim Wiberg
a4d02630c9
board/netconf: Define standard behavior for port LEDs
...
By default, assume that any LED with the function "tp", "sfp" or
"port" is attached to either an Ethernet PHY or MAC, with support for
offloading the "netdev" trigger.
Use green LEDs to indicate link/activity.
Disable any yellow LEDs for now, later on we can add alarm indications
etc. to these.
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
6ce7f01d64
package/iito: Bump to 1.1.0
...
Needed to fix a memory leak, and to get access to the new "led-group"
driver.
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
365ad5d565
board/aarch64: alder: Add LED setup for 1G ports
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
c4f8dadde0
board/aarch64: alder: Add LED setup for 10G ports
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
405aa6510d
kernel: Enable netdev LED trigger
...
This trigger can be offloaded into hardware by the PHY or MAC LED
attached to the netdev in question.
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
febb998702
kernel: Bump to 6.5.11 + kkit-linux-6.5.y
...
6.5.11: Pull latest fixes from stable tree
kkit-linux-6.5.y: LED support for 88X3310 PHY and 88E6393X switch.
2023-11-19 08:50:19 +01:00
Tobias Waldekranz and Joachim Wiberg
55afbb2a94
board/netconf: Only use iitod on netconf builds
...
None of the panic/failure/startup conditions make any sense on classic
builds where confd is not running.
2023-11-19 08:50:19 +01:00
Joachim Wiberg
072c3c6394
configs: enable our LED daemon iito in default builds
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-18 16:13:56 +01:00
Joachim Wiberg
aceafb7555
package/iito: fix copy-paste error from confd.mk
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-18 16:13:27 +01:00
Joachim Wiberg
0810163528
configs: add missing iproute2 package, regression in 5031ff6
...
When dropping the net package in 5031ff6 , a rebuild + test was not made
before pusing to main. As a result Infix suddenly lost one of its most
important packages, iproute2.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-18 16:02:19 +01:00
Joachim Wiberg
cc6232bf38
package/iito: relocate Finit conf and add tmpfiles.d for /run/led
...
Relocate Finit conf to package, like klish and confd. Add condition to
ensure it is not started before mdev/udevd are up and kernel LED modules
have been loaded properly.
Also, add tmpfiles.conf to ensure /run/led is recreated at every boot.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-18 14:49:56 +01:00
Joachim Wiberg
2caf729ee8
github: enable building local src in host mode for analysis
...
Install libyang and sysrepo from source, too old packages in ubuntu-latest.
[skip ci]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 18:04:18 +01:00
Joachim Wiberg
005eb58958
src: add support for host build check, for Coverity Scan
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 12:59:39 +01:00
Joachim Wiberg
ff69fcfa69
libsrx: make autogen.sh executable
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 10:40:18 +01:00
Joachim Wiberg
41a14d3ca6
statd: refactor Makefile for host build
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 10:40:18 +01:00
Joachim Wiberg
c529f06cf0
statd: fix gcc warning, "format not a string literal"
...
error: format not a string literal and no format arguments [-Werror=format-security]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 10:40:17 +01:00
Joachim Wiberg
04046437d7
confd: fix gcc warnings, "format not a string literal"
...
error: format not a string literal and no format arguments [-Werror=format-security]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 10:40:17 +01:00
Joachim Wiberg
f7d1a72511
confd: tell automake about generated files for cleaning
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 10:40:17 +01:00
Joachim Wiberg
5031ff6224
net: drop unused 'net' package, replaced by dagger
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-17 09:49:32 +01:00
Mattias Walström and Joachim Wiberg
1fd98758ba
frr: add specific configuraion file
...
The new default behaviour is one gigantic file (frr.conf)
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
2bcc9dbb3a
vlan_ping: add some negative test
...
Test that it works when removing interfaces.
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
171824c570
Add more memory to qemu devices
...
Since we now have FRR, there is not much memory left.
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
ef740a8abc
test: routing/static_routing: Sleep some to wait FRR startup
...
This should be replaced with reading the operational status.
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
e6de267e29
Update qnenth submodule
...
Make the ports for the console at the qemu instances deterministic
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
10b4b761c5
Routing: Limit to one instance per routing protocol
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
85386382e3
Add FRR do defconfig
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
4ea1a682da
Add test-case for a static routing
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
a4cb66b642
infix-routing needs to be imported before infix-interfaces
...
Due to that infix-routing has a deviated node that depends on
a deviated node in infix-interfaces.
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
4768cae603
Expose ports 9000-9050 for console connections outside docker
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
0b1bd9e8a0
Implement IPv4 static routing in ietf-routing
...
Only config no operational state yet.
routing
routing/control-plane-protocols
control-plane-protocol static name default
static-routes
ipv4 route 192.168.200.0/24 next-hop special-next-hop blackhole
2023-11-17 07:19:28 +01:00
Mattias Walström and Joachim Wiberg
03dbb409eb
static-routing: Add model for ipv4/ipv6 routing
2023-11-17 07:19:28 +01:00
Henrik Nordstrom and Joachim Wiberg
b36568bcb7
board/aarch64: alder: Watchdog support
2023-11-16 19:51:52 +01:00
Joachim Wiberg
e7c6f255fd
.clang-format: drop green goblin alignment
...
[skip ci]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
e26208afeb
confd: reindent with new .clang-format (example)
...
[skip ci]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
36175f599e
Some use-package help for Emacs users
...
[skip ci]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
715d17f475
statd: minor, cleanup, license headers
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
485e4256a3
confd: minor, whitespace
...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
8af048462d
src: proposed coding style for C, Linux++
...
The intention of this is to serve as a help/guidance for both devs and
reviewers of pull requests.
Baseline is taken from Linux v6.5.6, with some (possibly) controversial
additions (at the end of the file):
- Do not enforce max line length
- Alignment of variables, both when assigning and declaring
- Use spaces to adjust when leading tabs are not enough (as Emacs)
I've also added a couple of exceptions for macros like TAILQ_FOREACH()
which are used as control statments (if, while, for), so the opening
brace should be on the same line -- otherwise clang-format thinkts we
are creating a recursive function ...
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:35:43 +01:00
Joachim Wiberg
c867c8bd15
.github: initial workflow for Coverity Scan
...
[skip ci]
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-16 10:06:23 +01:00
Joachim Wiberg
0de25f9c19
patches/netsnmp: add pid readiness signaling for Finit
...
This patch adds PID readiness notification to Net-SNMP. This is
required for synchronizing processes like subagents.
PID readiness is similar to systemd READY=1 notification, which
Finit supports, but Net-SNMP only supports that at first startup
not after SIGHUP.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com >
2023-11-15 15:09:14 +01:00