peter/infix
1
0
Fork 0
mirror of https://github.com/kernelkit/infix.git synced 2026-08-06 07:33:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

confd: check if user has administrator rights for shell selection

Browse Source 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg
2024-06-03 23:05:04 +02:00
committed by Tobias Waldekranz
parent 43d68289b9
commit 5f07fc9d9f
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/confd/src/ietf-system.c
+11 -5
View File
@@ -668,6 +668,7 @@ static int is_valid_username(const char *user)
static char *sys_find_usable_shell(sr_session_ctx_t *sess, char *name)
{
bool is_admin = is_admin_user(sess, name);
char *shell = NULL, *conf = NULL;
char xpath[256];
sr_data_t *cfg;
@@ -682,17 +683,22 @@ static char *sys_find_usable_shell(sr_session_ctx_t *sess, char *name)
/* Verify the configured shell exists (and is a login shell) */
if (conf) {
struct { char *name, *shell; } shells[] = {
{ "infix-shell-type:sh", "/bin/sh" },
{ "infix-shell-type:bash", "/bin/bash" },
{ "infix-shell-type:clish", "/bin/clish" },
{ "infix-shell-type:false", "/bin/false" },
struct { char *name, *shell; bool admin; } shells[] = {
{ "infix-shell-type:sh", "/bin/sh", true },
{ "infix-shell-type:bash", "/bin/bash", true },
{ "infix-shell-type:clish", "/bin/clish", false },
{ "infix-shell-type:false", "/bin/false", false },
};
for (size_t i = 0; i < NELEMS(shells); i++) {
if (strcmp(shells[i].name, conf))
continue;
if (!is_admin && shells[i].admin) {
WARN("Selected login shell for %s only allowed for administrators!", name);
break;
}
shell = shells[i].shell;
break;
}