mDNS-SD was added in Windows 10 Creators Update[1] (build 1703), relased April 11, 2017. This makes SSDP no longer critical for finding an Infix device in Windows, both ping infix-01-02-03.local and using Chrome work. Since all major operating systems now support mDNS-SD[2] we've decided to standardize on that and LLDP for Infix and its derivatives. Other reasons for dropping it include, but is not limited to: lack of IPv6 in the implementation we use, and potential security implications[3]. [1]: https://en.wikipedia.org/wiki/Windows_10,_version_1703 [2]: https://techcommunity.microsoft.com/t5/networking-blog/mdns-in-the-enterprise/ba-p/3275777 [3]: https://blog.cloudflare.com/ssdp-100gbps/ Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Checklist for Updating Docker Image
This directory holds the Dockerfile and any extras needed to build and update the infix-test container image used for the test system.
The following is a checklist/reminder to maintainers for how to update the image, e.g., with missing Alpine packages.
-
Update the Dockerfile
cd test/docker/ edit Dockerfile -
Build the new image version, for latest version, see released images here: https://github.com/kernelkit/infix/pkgs/container/infix-test in this example we use version 0.4:
docker build -t ghcr.io/kernelkit/infix-test:0.4 . -
Update the
test/envfile to use the new version -
Verify your new image works properly (remember to remove your
~/.infix-test-venv) -
Send PR to co-maintainer for review
The co-maintainer should then verify themselves before approving the PR. A crucial step to remember is to:
-
Push the new image version to https://ghcr.io. For details on how to do this, see this excellent guide to the GitHub Container Registry:
-
Shorthand after setup (above):
echo $CR_PAT | docker login ghcr.io -u troglobit --password-stdin docker push ghcr.io/kernelkit/infix-test:0.4 -
Merge the PR to the
mainbranch.
Note: the co-maintainer may delegate the chore of uploading the new image to the one who prepared the PR (you), provided of course they have the access rights to do so.