Joachim Wiberg
9b83b82754
Also, update docker/README, because after last confusing update I couldn't follow my own instructions. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
1.8 KiB
Checklist for Updating Infamy Docker Image
This directory holds the Dockerfile and any extras needed to build and update the infix-test container image used for the test system.
Important
Remember the final
.in thedocker buildcommand, otherwise the build directory will be test/docker/ and you will get COPY errors!
Build Checklist
The following is a checklist/reminder to maintainers for how to update the image, e.g., with missing Alpine packages:
-
Update the Dockerfile
cd test/ edit docker/Dockerfile -
Build the new image version, for latest version, see released images here: https://github.com/kernelkit/infix/pkgs/container/infix-test in this example we use version 2.7:
docker build -f docker/Dockerfile -t ghcr.io/kernelkit/infix-test:2.7 . -
Update the
test/.envfile to use the new version -
Verify your new image works properly (remember to remove your
~/.infix/venv) -
Send PR to co-maintainer for review
Upload New Image
The co-maintainer should then verify themselves before approving the PR. A crucial step to remember is to:
-
Push the new image version to https://ghcr.io. For details on how to do this, see this excellent guide to the GitHub Container Registry:
-
Shorthand after setup (above):
echo $CR_PAT | docker login ghcr.io -u troglobit --password-stdin docker push ghcr.io/kernelkit/infix-test:2.7 -
Merge the PR to the
mainbranch.
Note
The co-maintainer may delegate the chore of uploading the new image to the one who prepared the PR (you), provided of course they have the access rights to do so.