From f5e37bba58a1fc3a2ef180b3850035df367d2709 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Wed, 6 Mar 2024 08:49:23 +0100 Subject: [PATCH] confd: check return value on failure to read pvid from a bridge-port Signed-off-by: Joachim Wiberg --- src/confd/src/ietf-interfaces.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/confd/src/ietf-interfaces.c b/src/confd/src/ietf-interfaces.c index 1813d445..e0224398 100644 --- a/src/confd/src/ietf-interfaces.c +++ b/src/confd/src/ietf-interfaces.c @@ -736,9 +736,11 @@ static int netdag_gen_ethtool(struct dagger *net, struct lyd_node *cif, struct l static int bridge_diff_vlan_port(struct dagger *net, FILE *br, const char *brname, int vid, const char *brport, int tagged, enum lydx_op op) { - int pvid = 0; + int err, pvid = 0; - srx_get_int(net->session, &pvid, SR_UINT16_T, IF_XPATH "[name='%s']/bridge-port/pvid", brport); + err = srx_get_int(net->session, &pvid, SR_UINT16_T, IF_XPATH "[name='%s']/bridge-port/pvid", brport); + if (err) + return err; if (op != LYDX_OP_CREATE) { fprintf(br, "vlan del vid %d dev %s\n", vid, brport);