diff --git a/board/common/qemu/qemu.sh b/board/common/qemu/qemu.sh index 3813d4b4..115a21bb 100755 --- a/board/common/qemu/qemu.sh +++ b/board/common/qemu/qemu.sh @@ -17,9 +17,10 @@ # # ./qemu.sh -h # +# shellcheck disable=SC3037 # Local variables -imgdir=$(readlink -f $(dirname "$0")) +imgdir=$(readlink -f "$(dirname "$0")") prognm=$(basename "$0") usage() @@ -54,19 +55,20 @@ die() load_qemucfg() { - local tmp=$(mktemp -p /tmp) + tmp=$(mktemp -p /tmp) - grep ^CONFIG_QEMU_ $1 >$tmp - . $tmp - rm $tmp + grep ^CONFIG_QEMU_ "$1" >"$tmp" + # shellcheck disable=SC1090 + . "$tmp" + rm "$tmp" [ "$CONFIG_QEMU_MACHINE" ] || die "Missing QEMU_MACHINE" [ "$CONFIG_QEMU_ROOTFS" ] || die "Missing QEMU_ROOTFS" - [ "$CONFIG_QEMU_KERNEL" -a "$CONFIG_QEMU_BIOS" ] \ + [ -n "$CONFIG_QEMU_KERNEL" ] && [ -n "$CONFIG_QEMU_BIOS" ] \ && die "QEMU_KERNEL conflicts with QEMU_BIOS" - [ ! "$CONFIG_QEMU_KERNEL" -a ! "$CONFIG_QEMU_BIOS" ] \ + [ -z "$CONFIG_QEMU_KERNEL" ] && [ -z "$CONFIG_QEMU_BIOS" ] \ && die "QEMU_KERNEL or QEMU_BIOS must be set" } @@ -93,7 +95,7 @@ append_args() if [ "$CONFIG_QEMU_ROOTFS_INITRD" = "y" ]; then # Size of initrd, rounded up to nearest kb - local size=$((($(stat -c %s $CONFIG_QEMU_ROOTFS) + 1023) >> 10)) + size=$((($(stat -c %s "$CONFIG_QEMU_ROOTFS") + 1023) >> 10)) echo -n "root=/dev/ram0 ramdisk_size=${size} " elif [ "$CONFIG_QEMU_ROOTFS_VSCSI" = "y" ]; then echo -n "root=PARTLABEL=primary " @@ -198,8 +200,8 @@ host_args() net_dev_args() { - local name="e$1" - local mac=$(printf "02:00:00:00:00:%02x" $1) + name="e$1" + mac=$(printf "02:00:00:00:00:%02x" "$1") echo -n "-device $CONFIG_QEMU_NET_MODEL,netdev=$name,mac=$mac " echo "$name $mac" >>"$mactab" @@ -216,14 +218,12 @@ net_args() echo -n "-netdev bridge,id=e1,br=$CONFIG_QEMU_NET_BRIDGE_DEV " net_dev_args 1 elif [ "$CONFIG_QEMU_NET_TAP" = "y" ]; then - for i in $(seq 1 $(($CONFIG_QEMU_NET_TAP_N))); do + for i in $(seq 1 "$CONFIG_QEMU_NET_TAP_N"); do echo -n "-netdev tap,id=e$i,ifname=qtap$i " - net_dev_args $i + net_dev_args "$i" done elif [ "$CONFIG_QEMU_NET_USER" = "y" ]; then - local useropts= [ "$CONFIG_QEMU_NET_USER_OPTS" ] && useropts=",$CONFIG_QEMU_NET_USER_OPTS" - echo -n "-netdev user,id=e1${useropts} " net_dev_args 1 else @@ -301,8 +301,7 @@ run_qemu() fi fi - local qemu - read qemu <