From a88391afa24fd69b2fd1ea19ef27b74bb63a2453 Mon Sep 17 00:00:00 2001 From: Tobias Waldekranz Date: Wed, 30 Aug 2023 10:55:37 +0200 Subject: [PATCH] common: nameif: Drop the assumption that any eN interface is a port The port marker is intended to be used as a hint to the auto-factory-config generator, so that it can create a bridge for all switch ports by default. Therefore, revert to only include ports that devlink reports as "flavour physical". If we want to test this functionality in QEMU, we can use Rocker, the virtual switch, instead. --- board/common/rootfs/lib/infix/nameif | 7 ------- 1 file changed, 7 deletions(-) diff --git a/board/common/rootfs/lib/infix/nameif b/board/common/rootfs/lib/infix/nameif index 9a64ba63..4ff8e3d9 100755 --- a/board/common/rootfs/lib/infix/nameif +++ b/board/common/rootfs/lib/infix/nameif @@ -35,12 +35,5 @@ for iface in $ports; do ip link set "$iface" group port done -# Testing, e.g., using /etc/mactab may use TAP devices to create -# emulated switch ports, make sure to mark them as well -ports=$(ip -json link | jq -r '.[].ifname | match("^e[[:digit:]]+").string') -for iface in $ports; do - ip link set "$iface" group port -done - # At least loopback in iface group ip link set lo group iface