From 6ae4e33a84aa1e82635aade667a51c3366062546 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20Walstr=C3=B6m?= Date: Thu, 15 Jan 2026 13:19:03 +0100 Subject: [PATCH] banana-pi: Do not try to set autoneg on the SFP ports This will just crash dagger. They are already in autoneg, thats all they support. --- .../bananapi,bpi-r3/etc/product/interface-quirks.json | 11 +++++++++++ src/confd/src/ieee802-ethernet-interface.c | 3 +++ 2 files changed, 14 insertions(+) create mode 100644 board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3/etc/product/interface-quirks.json diff --git a/board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3/etc/product/interface-quirks.json b/board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3/etc/product/interface-quirks.json new file mode 100644 index 00000000..293eca46 --- /dev/null +++ b/board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3/etc/product/interface-quirks.json @@ -0,0 +1,11 @@ +{ + "sfp1": { + "comment": "Reports it supports autoneg, but if setting it, dagger crashes", + "broken-autoneg": true + }, + "sfp2": { + "comment": "Reports it supports autoneg, but if setting it, dagger crashes", + "broken-autoneg": true + } + +} diff --git a/src/confd/src/ieee802-ethernet-interface.c b/src/confd/src/ieee802-ethernet-interface.c index 53f156eb..b63fbdb1 100644 --- a/src/confd/src/ieee802-ethernet-interface.c +++ b/src/confd/src/ieee802-ethernet-interface.c @@ -69,6 +69,9 @@ static int netdag_gen_ethtool_autoneg(struct dagger *net, struct lyd_node *cif) int mbps, err = 0; FILE *fp; + if (iface_has_quirk(ifname, "broken-autoneg")) + return SR_ERR_OK; + if (iface_has_quirk(ifname, "phy-detached-when-down")) phase = NETDAG_INIT_POST;