From eb971694bbc87faefa7d0d98d16f81ca97e20cf2 Mon Sep 17 00:00:00 2001
From: Dan Helfman <witten@torsion.org>
Date: Wed, 3 Sep 2025 10:20:53 -0700
Subject: [PATCH] PR feedback.

---
 borgmatic/hooks/data_source/dump.py       | 2 +-
 borgmatic/hooks/data_source/postgresql.py | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/borgmatic/hooks/data_source/dump.py b/borgmatic/hooks/data_source/dump.py
index e835d0cf..63161464 100644
--- a/borgmatic/hooks/data_source/dump.py
+++ b/borgmatic/hooks/data_source/dump.py
@@ -47,7 +47,7 @@ def write_data_source_dumps_metadata(borgmatic_runtime_directory, hook_name, dum
     with open(
         os.path.join(borgmatic_runtime_directory, hook_name, 'dumps.json'), 'w'
     ) as metadata_file:
-        json.dump([dump._asdict() for dump in dumps_metadata], metadata_file)
+        json.dump([dump._asdict() for dump in dumps_metadata], metadata_file, sort_keys=True)
 
 
 def parse_data_source_dumps_metadata(dumps_json):
diff --git a/borgmatic/hooks/data_source/postgresql.py b/borgmatic/hooks/data_source/postgresql.py
index 5712ecc6..c4fc55bf 100644
--- a/borgmatic/hooks/data_source/postgresql.py
+++ b/borgmatic/hooks/data_source/postgresql.py
@@ -256,12 +256,10 @@ def dump_data_sources(
                     ),
                 )
 
-        if not dry_run:
-            dump.write_data_source_dumps_metadata(
-                borgmatic_runtime_directory, 'postgresql_databases', dumps_metadata
-            )
-
     if not dry_run:
+        dump.write_data_source_dumps_metadata(
+            borgmatic_runtime_directory, 'postgresql_databases', dumps_metadata
+        )
         patterns.append(
             borgmatic.borg.pattern.Pattern(
                 os.path.join(borgmatic_runtime_directory, 'postgresql_databases'),